fix h2 rpc_dump memory leak bug#2661
Merged
wwbmmm merged 1 commit intoJun 13, 2024
Merged
Conversation
GreateCode
changed the title
Contributor
Author
Contributor
Author
|
@wwbmmm 合下？ |
Contributor
|
LGTM |
chenBright
pushed a commit
to chenBright/brpc
that referenced
this pull request
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
h2 rpc_dump时 内存泄漏。
具体是http和h2都走ProcessHttpRequest方法，在处理rpc_dump时，先AskToBeSampled创建堆对象再判is_http2，若是http2无释放堆对象逻辑。
发压cmd：rpc_press -protocol=h2 xxxx
What is changed and the side effects?
Changed:
h2 req不做AskToBeSampled
修复前：
brpc_h2_rpc_dump_mem_leak_bug.pdf
修复后：
brpc_h2_rpc_dump_mem_leak_fixed.pdf
Side effects:
无
Check List: